On Tue, Mar 16, 2010 at 02:30:05PM +0300, Dan Carpenter wrote:
> drivers/net/wireless/ath/ath5k/phy.c +2603 
> ath5k_combine_pwr_to_pdadc_curves(66)
> 
>   2587                  /* If pdadc_0 is negative, we need to extrapolate
>   2588                   * below this pdgain by a number of pwr_steps */
>   2589                  while ((pdadc_0 < 0) && (pdadc_i < 128)) {

...
>   2601                  /* Fill pdadc_out table */
>   2602                  while (pdadc_0 < max_idx)
>   2603                          pdadc_out[pdadc_i++] = pdadc_tmp[pdadc_0++];
> 
>       pdadc_i would be too high and pdadc_0 could maybe still be less 
>       than zero.

Thanks, Dan.

I guess that second one should also range check pdadc_i, though I'm 
not the most familiar with this code.. Nick?

-- 
Bob Copeland %% www.bobcopeland.com

_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to