On Fri, Jun 4, 2010 at 2:21 PM, Luis R. Rodriguez <lrodrig...@atheros.com> wrote: > On Fri, Jun 04, 2010 at 12:30:09PM -0700, John W. Linville wrote: >> On Wed, May 19, 2010 at 10:31:48AM +0900, Bruno Randolf wrote: >> > Allow setting TX and RX antenna configuration via nl80211/cfg80211. >> > >> > The antenna configuration is defined as a bitmap of allowed antennas. This >> > bitmap is 8 bit at the moment, each bit representing one antenna. If >> > multiple >> > antennas are selected, the driver may use diversity for receive and >> > transmit. >> > This allows for a simple, yet flexible configuration interface for >> > antennas, >> > while drivers may reject configurations they cannot support. >> > >> > Signed-off-by: Bruno Randolf <b...@einfach.org> >> >> This spawned a long thread, that isn't clearly resolved IMHO. So, I >> haven't merged it, or the other patches that follow it in this series. >> >> Am I mistaken? Did this get resolved? If not, are some of the later >> patches still interesting? >> >> Unless I hear otherwise, I'll be dropping the rest of this series... > > I don't think the API is defined clean enough yet and can yield > inconsistant interpretations. I'd like to see this clarified on > the documentation for both legacy and 802.11n. If the plan is > to support only legacy right now then I think the API can be > simpler and clearer with only three options passed, Fixed_A > Fixed_B and diversity.
Oh and the rest of the series should not be dropped but I did think it would have been prudent for the patches to be separated and that this particular set of patches for antenna API be separated out to another series so that the other stuff can get merged. Luis _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
