On Tue June 15 2010 22:44:40 Holger Schurig wrote:
> @@ -2770,7 +2767,7 @@ ath5k_intr(int irq, void *dev_id)
>                                 *     RXE bit is written, but it doesn't
> work at
>                                 *     least on older hardware revs.
>                                 */
> -                               sc->rxlink = NULL;
> +                               sc->stats.rxeol_intr++;
> 
> Here you increment it.
> 
>                         }
>                         if (status & AR5K_INT_TXURN) {
>                                 /* bump tx trigger level */
> diff --git a/drivers/net/wireless/ath/ath5k/base.h
> b/drivers/net/wireless/ath/ath5k/base.h
> index 86c90f4..dc1241f 100644
> --- a/drivers/net/wireless/ath/ath5k/base.h
> +++ b/drivers/net/wireless/ath/ath5k/base.h
> @@ -137,6 +137,7 @@ struct ath5k_statistics {
> 
>         unsigned int mib_intr;
>         unsigned int rxorn_intr;
> +       unsigned int rxeol_intr;
>  };
> 
>  #if CHAN_DEBUG
> 
> Here you define it.
> 
> 
> However, I fail to see where you use (e.g. read) it. So right now you added
> a write-only variable.

true, it looks quite pointless at the moment, but there are a few other cases 
like this (rxorn_intr). i want to add a debugfs file to read these counters 
later.

bruno
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to