On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > Even without my patch, WEP does not work with multiple vifs.
Are you sure about that? Why would there be any issues in using software crypto for decrypting WEP frames while everything else is done in hardware? I'm really interested in cases where only one of the vifs is using WEP, but this should work even with multiple WEP vifs. The key is in mac80211 using more details of the frame header in selecting which key to use than the hardware key cache. > My patch just adds a special case for WEP, so it does not break anything for > the other use cases. It improves the performance for the one vif case where > WEP works right now. As far as I can tell, it will break all multi-vif cases where at least one of the vifs is using WEP (which would be one of the only acceptable uses of WEP as a temporary upgrade path while providing more reasonable security on other vifs). As such, I would have to NAK this patch in its current form. To make this acceptable, the patch would need to handle a case where multiple vifs are added (which may happen either before or after the WEP keys would be set to default key indexes) and prevent the use of those key indexes (which would include removing the already configured keys in case of vif added after the WEP configuration on another vif). Another alternative could be to figure out whether some of the new key cache functionality could be used to avoid the problems in some cases, but that may not be feasible with all the hardware revisions supported by ath5k. -- Jouni Malinen PGP id EFC895FA _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
