On 05/07/2012 10:33 AM, Joe Perches wrote:
> On Mon, 2012-05-07 at 10:23 -0700, gree...@candelatech.com wrote:
>> From: Ben Greear<gree...@candelatech.com>
>>
>> This returns many of the values that formerly could
>> only be obtained from debugfs. This should be an
>> improvement when trying to access these counters
>> programatically. Currently this support is only
>> enabled when DEBUGFS is enabled because otherwise
>> these stats are not accumulated.
>
> trivia:
>
> []
>> +#define ATH9K_SSTATS_LEN ARRAY_SIZE(ath9k_gstrings_stats)
>
> I think there's not much value in this #define
>
>> +static int ath9k_get_et_sset_count(struct ieee80211_hw *hw,
>> + struct ieee80211_vif *vif, int sset)
>> +{
>> + if (sset == ETH_SS_STATS)
>> + return ATH9K_SSTATS_LEN;
>> + return 0;
>> +}
>
> Is this the only use?
No, there is a check later that does a BUG_ON if our
we have screwed up the indexing of the stats.
That helps catch trivial problems with adding a stat
but not the string, or vice versa.
Thanks,
Ben
--
Ben Greear <gree...@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
