On Fri, Nov 30, 2012 at 11:27 PM, Adrian Chadd <adr...@freebsd.org> wrote:
> .. 0x24? Why's it ANDing with that?
Not my code ! Its already present in debgufs.c
How big is that PHY error array?
>
> Enum is indexed till 37
> And there's a separate RX PHY error mask register you can set to
> 0xffffffff for experiment:
>
> ar5212reg.h:#define AR_PHY_ERR 0x810c /* Phy error filter */
>
> Okay, thanks.
-Abhinav
>
>
> Adrian
>
> On 30 November 2012 20:20, abhinav narain <abhinavnarai...@gmail.com>
> wrote:
> > I won't be touching the ANI counters.
> > I have the following question instead :
> >
> > In debug.c ;
> > After enabling the PHYERR, the
> > if (rs->rs_status & ATH9K_RXERR_PHY) {
> > RX_STAT_INC(phy_err);
> > phyerr = rs->rs_phyerr & 0x24;
> > RX_PHY_ERR_INC(phyerr);
> > }
> > UNDERRUN : 7723847
> > TIMING : 0
> > PARITY : 0
> > RATE : 0
> > TOR : 0
> > OFDM-TIMING : 0
> > OFDM-SIGNAL-PARITY : 0
> > OFDM-RATE : 0
> > OFDM-LENGTH : 0
> > OFDM-POWER-DROP : 0
> > OFDM-SERVICE : 0
> > OFDM-RESTART : 0
> > FALSE-RADAR-EXT : 0
> > CCK-TIMING : 0
> > CCK-HEADER-CRC : 0
> > CCK-RATE : 0
> > CCK-SERVICE : 0
> > CCK-RESTART : 0
> >
> > LENGTH : 1238241
> > CCK-LENGTH : 80508
> > are the only PHY errors that are shown in debugfs output.
> > I wanted to know if changing the mask would enable other error counters
> too
> > ?
> > Or the mask itself is such that only the above PHYERRs are shown.
> > There is no documentation of what each represent.
> >
> > -Abhinav
> >
> >
> > On Fri, Nov 30, 2012 at 8:25 PM, Adrian Chadd <adr...@freebsd.org>
> wrote:
> >>
> >> Hi,
> >>
> >>
> >> On 30 November 2012 16:34, abhinav narain <abhinavnarai...@gmail.com>
> >> wrote:
> >> > hi,
> >> > In ath9k/reg.h,
> >> > there are some constants for the PHY error counters
> >> > #define AR_FILT_CCK 0x8128
> >> >
> >> > #define AR_PHY_ERR_1 0x812c
> >> > #define AR_PHY_ERR_MASK_1 0x8130
> >> >
> >> > #define AR_PHY_ERR_2 0x8134
> >> > #define AR_PHY_ERR_MASK_2 0x8138
> >> >
> >> > Can I change them to 0xffff or the mask ? or the ERR are for a purpose
> >> > and
> >> > will degrade router performance if modified ?
> >>
> >> The counting itself won't cause problems. But right now with the ANI
> >> code it treats those two PHY_ERR_{1,2} registers as special. So if you
> >> change those masks, you'll change how ANI responds.
> >>
> >> The ANI code also may still generate MIB interrupts when the counters
> >> overflow. If you add PHY errors to those, the MIB counters will
> >> overflow more frequently and you'll end up with more interrupts.
> >>
> >> So, play safely :-)
> >>
> >>
> >> Adrian
> >
> >
>
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
