Joe Perches <j...@perches.com> writes: > On Mon, 2013-05-20 at 10:12 +0300, Kalle Valo wrote: >> Michal Kazior <michal.kaz...@tieto.com> writes: >> >> > On 16/05/13 09:03, Joe Perches wrote: >> >> Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. >> >> >> >> Add macros to hold the "ATH10K_DBG_" mask portion of the functions. >> > >> > I'm not really fond of this idea. It's harder to locate symbols when >> > doing macro name concatenation. You can't jump to, e.g. WMI symbol >> > definition because it doesn't exist (ATH10K_DBG_WMI is what you >> > actually want). Although you don't look for this symbol often so I >> > guess it's okay-ish. >> >> That's a good point. I sometimes use cscope to find all messages with >> certain level, this patch makes that impossible. And I don't really see >> that we have problems with ATH10K_DBG_WMI being too long. > > from the diffstat: 12 files changed, 226 insertions(+), 260 deletions(-) > > Reducing the line count has value
Sure, but there's a limit to that as well. If it makes more difficult for the developers is it worth saving 30 lines? > grep -w works well for me, but I'm not a cscope user. I didn't know about -w, that's handy. Thanks. -- Kalle Valo _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
