On 5 July 2013 08:29, Kalle Valo <kv...@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kaz...@tieto.com> writes:
>
>> Split logic that prepares the device for BMI
>> phase/cleans up related resources.
>>
>> This is necessary for ath10k to be able to restart
>> hw on the fly without reloading the module.
>>
>> Signed-off-by: Michal Kazior <michal.kaz...@tieto.com>
>> ---
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/hif.h
>> +++ b/drivers/net/wireless/ath/ath10k/hif.h
>> @@ -46,8 +46,11 @@ struct ath10k_hif_ops {
>> void *request, u32 request_len,
>> void *response, u32 *response_len);
>>
>> + /* Post BMI phase, after FW is loaded. Starts regular operation */
>> int (*start)(struct ath10k *ar);
>>
>> + /* Clean up what start() did. This does not revert to BMI phase. If
>> + * desired so, call deinit() and init() */
>> void (*stop)(struct ath10k *ar);
>
> The last sentence in the comment can be removed, right? Or I
> misunderstand the meaning.
Oh. I didn't update the comment. It should state "call power_down()
and power_up()" since those function names have changed.
Otherwise we still expect either sequence:
* power_up() -> power_down() [-> power_up() ..]
* power_up() -> start() -> stop() -> power_down() [-> power_up() ..]
Pozdrawiam / Best regards,
Michał Kazior.
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
