Oleksij Rempel wrote:
> +     rx_stats = kzalloc(sizeof(struct ath_rx_status), GFP_KERNEL);
> +     if (unlikely(rx_stats == NULL)) {
> +             ath_err(common, "rx_stats allocation filed!\n");
> +             goto err_nofree;
> +     }
> +     rx_status_htc_to_ath(rx_stats, &rxbuf->rxstatus);
> +

This seems a little expensive, since this would happen for every packet,
and a memcpy is already done earlier, for storing the RX status in
rxbuf->rxstatus. Instead of using 'struct ath_htc_rx_status' in
'struct ath9k_htc_rxbuf', why can't 'struct ath_rx_status' be used ?
The values can be converted and stored directly, avoiding this alloc.

Sujith

_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Reply via email to