"Vittorio Gambaletta (VittGam)" <linux-wirel...@vittgam.net> writes:
>>> So, after seeing that the rest of the file is sorted this way (generic >>> section after the specific ones), I concluded that the 0x002A sorting >>> was wrong in the first place, and so is 0x0029. Then I sent this patch >>> to fix this. >> >> I can't see how changing the order in ath_pci_id_table[] would make any >> difference in functionality, but I might be missing something. > > It does: I've looked through the relevant code, and found that PCI device > matching from that table is done sequentially in pci_match_id() from > drivers/pci/pci-driver.c. > > So if a generic PCI_VDEVICE entry (that has both subvendor and subdevice IDs > set to PCI_ANY_ID) is put before a more specific one (PCI_DEVICE_SUB), then > the generic PCI_VDEVICE entry will match first and will be used. Ah, now it makes sense. Thanks for patiently explaining this to me :) So to tell the full story I'll change the commit log to something like below. Does it look ok to you? ---------------------------------------------------------------------- ath9k: Really fix LED polarity for some Mini PCI AR9220 MB92 cards. The active_high LED of my Wistron DNMA-92 is still being recognized as active_low on 4.7.6 mainline. When I was preparing my former commit 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards.") to fix that I must have somehow messed up with testing, because I tested the final version of that patch before sending it, and it was apparently working; but now it is not working on 4.7.6 mainline. I initially added the PCI_DEVICE_SUB section for 0x0029/0x2096 above the PCI_VDEVICE section for 0x0029; but then I moved the former below the latter after seeing how 0x002A sections were sorted in the file. So if a generic PCI_VDEVICE entry (that has both subvendor and subdevice IDs set to PCI_ANY_ID) is put before a more specific one (PCI_DEVICE_SUB), then the generic PCI_VDEVICE entry will match first and will be used. With this patch, 0x0029/0x2096 has finally got active_high LED on 4.7.6. Fixes: 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards.") Cc: <sta...@vger.kernel.org> #4.7+ Signed-off-by: Vittorio Gambaletta <linuxb...@vittgam.net> [kv...@qca.qualcomm.com: improve the commit log based on email discussions] Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> ---------------------------------------------------------------------- -- Kalle Valo _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel