Commit to Atlas310 and Head. Thanks all. >-----Original Message----- >From: Eric Hyche [mailto:[EMAIL PROTECTED] >Sent: 2008年5月15日 5:12 >To: Zhao, Halley; audio-dev@helixcommunity.org >Subject: RE: [Audio-dev] CR: Deal with an undefined return value from >Alsa-libto avoid crash > > >Looks good. > >============================================= >Eric Hyche ([EMAIL PROTECTED]) >Technical Lead >RealNetworks, Inc. > >> -----Original Message----- >> From: [EMAIL PROTECTED] >> [mailto:[EMAIL PROTECTED] On Behalf Of >> Zhao, Halley >> Sent: Wednesday, May 14, 2008 1:36 AM >> To: audio-dev@helixcommunity.org >> Subject: [Audio-dev] CR: Deal with an undefined return value >> from Alsa-libto avoid crash >> >> Synopsis: >> >> when we used Bluetooth earphone, snd_pcm_hw_params (an >> Alsa-lib API) sometimes >> >> gives an undefined value, it will cause helix engine >> crash. make a work around here. >> >> >> >> Overview: >> >> try to fix bug #8040: >> >> https://bugs.helixcommunity.org/show_bug.cgi?id=8040 >> >> " >> >> >> http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html >> >> int snd_pcm_hw_params ( snd_pcm_t * >> pcm, >> >> snd_pcm_hw_params_t * >> params >> >> ) >> >> Returns: >> >> 0 on success otherwise a negative error code >> >> " >> >> but when we use bluetooth earphone, sometimes we get >> a positive value ("1") >> >> from this function call, this will cause helix engine crash. >> >> though there should be some issue inside Bluez stack, >> helix engine should try to avoid crash here. >> >> When we accept this positive value as success, it will be ok. >> >> >> >> #8040 is reproduced on plugz(bluetooth-alsa) stack, it is >> out of date. >> >> when we switch to bluez-util stack, found the return value above. >> >> >> >> >> >> Files Added: >> >> No file added >> >> Files Modified: >> >> audlinux_alsa.cpp: (audio/device/platform/unix/audlinux_alsa.cpp) >> >> accept the positive value return from snd_pcm_hw_params >> >> >> >> Image Size and Heap Use impact (Client -Only): >> >> little >> >> Platforms and Profiles Affected: >> >> platform: linux-2.2-libc6-gcc32-i586 >> >> profile: helix-client-all-defines >> >> >> >> Distribution Libraries Affected: >> >> <helix-dbus-server.bin> >> >> Distribution library impact and planned action: >> >> <None> >> >> Platforms and Profiles Build Verified: >> >> Set BIF branch -> hxdbus_3_1_0_atlas >> >> Set Target(s) -> player_mid_all_installers >> >> Set Profile -> helix-client-all-defines >> >> System ID -> linux-2.2-libc6-gcc32-i586 >> >> Branch: >> >> HEAD, hxclient_3_1_0_atlas >> >> Copyright assignment: <MUST be one of the following statements > >> >> 2. Intel has signed and delivered a Joint Copyright Assignment >> >> to RealNetworks, and received acknowledgment that the >> >> agreement was received. >> >> Files Attached: >> >> alsa-audio.diff.txt >> >> >> >> ZHAO, Halley (Aihua) >> >> Email: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> >> >> Tel: +86(21)61166476 >> >> iNet: 8821-6476 >> >> SSG/OTC/UMD >> >> >> >>
_______________________________________________ Audio-dev mailing list Audio-dev@helixcommunity.org http://lists.helixcommunity.org/mailman/listinfo/audio-dev
