Hi,
It seems bug 9314 is duplicate to bug 9311.
Here the issue is the height of player is set to 325 (Default size 800 x 325),
now if we play matrix
video (attached in bug report in bugzilla) & then if we uncheck "menu &
caption" option then height
changes to 351 from 325 and now when we put a check on "menu & caption" option
then player sets to
800x351 similarly if we check uncheck "controls" option.
And height keep increasing by 26 as we check/uncheck again & again
(325->351->377...& so on).
Here my doubt is whether we want to make video window static or we want player
window static.
Also this can be fixed if we comment call of hxwindow_change_layout() function
call from
hxwindow_show_menu_and_caption() function (similarly from
hxwindow_show_controls).
Daniel: Can you please comment what kind of fix we were expecting, we want
static player window or
static video area?
Also can we comment call of hxwindow_change_layout() function call from
hxwindow_show_menu_and_caption() function
Thanks & Regards
Sushant Garg
----- Original Message -----
From: Sushant Garg
To: mmanjun...@real.com ; Leina Tani ; Daniel Yek
Cc: Sushant Garg ; upupp...@real.com
Sent: Monday, June 15, 2009 6:20 PM
Subject: Re: bug 9314 - fix needs work
Hi,
I looked into the bug & found it was not due to my changes, this is an old
bug which can be repro
after removing my changes from contextmenu_interface.c & contextmenu.glade.
However after debugging I find the reason of reproing but I need some time to
reach to the root
cause & to fix it.
Here is the debugging information & reason why I need more time to fix it.
There is a code in player/app/gtk/mainapp.cpp
hxwindow_show_menu_and_caption(HXMainWindow* window, gboolean show)
{
gboolean current_show = GTK_WIDGET_VISIBLE(window->menu_bar)? TRUE: FALSE;
if(show != current_show)
{
/* Show/hide the widget */
if(show)
{
gtk_widget_show(window->menu_bar);
gtk_window_set_decorated(GTK_WINDOW(window->window), TRUE);
}
else
{
gtk_widget_hide(window->menu_bar);
gtk_window_set_decorated(GTK_WINDOW(window->window), FALSE);
}
hxwindow_change_layout(window,
FALSE); // resize_top_level
}
}
Now in this function there is a call of "hxwindow_change_layout" function
which is used to change
the size of player window.
Under this function in our case code goes to set "CUSTOM_SIZE" (around line
670) of RealPlayer
window.
case CUSTOM_SIZE:
default:
desired_window_height = window->custom_zoom_height;
desired_window_width = window->custom_zoom_width;
break;
Here we are calculating desired_window_height/width from
window->custom_zoom_height/width
which is setting from function
hmw_player_metadata_display_box_size_allocate() (around line 3960)
Now I have following doubts due to which I need some more time to debug & fix
this issue.
- From where we are getting allocation->width/height, which we were
setting in
window->custom_zoom_width/height & why it is changing?
- Why we are calling hxwindow_change_layout() function from
hxwindow_show_menu_and_caption()
function?
Thanks & Regards
Sushant Garg
----- Original Message -----
From: Leina Tani
To: sg...@real.com ; mmanjun...@real.com
Cc: lt...@real.com
Sent: Saturday, June 13, 2009 2:22 AM
Subject: bug 9314 - fix needs work
Hi Guys,
Umakanth reopened but 9314 today due to issues that were introduced with
trying to fix the bug.
I've assigned the bug to Manju but since Sushant did the original fix, please
work together to
correct the bug ASAP as this will be visible to Phoenix.
Thanks,
-leina
Leina Tani
Program Manager
Helix Community
Real Networks, Inc.
lt...@real.com
http://www.helixcommunity.org
_______________________________________________
Audio-dev mailing list
Audio-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
