On Wed, Mar 12, 2025 at 04:16:36PM -0400, Paul Moore wrote: > On Wed, Mar 12, 2025 at 4:02 PM Andy Shevchenko > <[email protected]> wrote: > > > > audit_log_vformat() is using printf() type of format, and compiler > > is not happy about this: > > > > kernel/audit.c:1978:9: error: function ‘audit_log_vformat’ might be a > > candidate for ‘gnu_printf’ format attribute > > [-Werror=suggest-attribute=format] > > kernel/audit.c:1987:17: error: function ‘audit_log_vformat’ might be a > > candidate for ‘gnu_printf’ format attribute > > [-Werror=suggest-attribute=format] > > > > Fix the compilation errors by adding __printf() attribute.
> It would be good to list the compiler version/flags that triggers this > error in the patch description CONFIG_WERROR=y (this is default), gcc (Debian 14.2.0-17) 14.2.0, `make W=1`. > as I've compiled the audit code quite a bit and haven't seen these errors :) Good for you, I have 100% reproducibility of this :-) I'll do a v2 today. -- With Best Regards, Andy Shevchenko
