On Wed, Aug 13, 2025 at 08:39:33AM -0700, Casey Schaufler wrote: > On 8/12/2025 10:38 PM, Dan Carpenter wrote: > > Someone got a bit carried away deleting tabs. Add it back. > > Of course, it should be the way you want it to be, but I don't > see the reasoning. Help me understand. >
The "call_panic = 1;" has to be indent one tab more than the if (audit_log_pid_context()) check otherwise static checkers complain that the if statement isn't indented. 1771 ________for (aux = context->aux_pids; aux; aux = aux->next) { 1772 ________ struct audit_aux_data_pids *axs = (void *)aux; 1773 ________ 1774 ________ for (i = 0; i < axs->pid_count; i++) 1775 ________ ________if (audit_log_pid_context(context, axs->target_pid[i], 1776 ________ ________ axs->target_auid[i], 1777 ________ ________ axs->target_uid[i], 1778 ________ ________ axs->target_sessionid[i], 1779 ________ ________ &axs->target_ref[i], 1780 ________ ________ axs->target_comm[i])) 1781 ________ ________ call_panic = 1; 1782 ________} regards, dan carpenter