Hi J.R., It has been a while after getting this patch. But recently I encountered kernel panic and it seems to me this fix is somehow related. (either regression or revealed hidden issue) The reason that I'm thinking like that is if I remove this fix from mainline, I don't get kernel panic (of course multiple aufs root won't get notified)
Below is kernel panic message which is from assertion failure by aufs/debug.c after enabling debug module parameter. Do you have any thoughts? Regards, Joonwoo --- aufs2.1-standalone.tree-32-20110124 --- aufs h_d_revalidate:915:app[24484]: DEBUG: b1, home aufs h_d_revalidate:915:app[24484]: DEBUG: b1, app aufs h_d_revalidate:915:app[24484]: DEBUG: b1, home aufs h_d_revalidate:915:app[24484]: DEBUG: b1, app aufs h_d_revalidate:915:app[24484]: DEBUG: b1, incoming aufs lock_hdir_lkup_wh:162:app[24484]: DEBUG: incoming aufs au_wbr_create_tdp:305:app[24484]: DEBUG: b0 aufs au_wr_dir:317:app[24484]: DEBUG: bstart 1, bcpup 0 ------------[ cut here ]------------ kernel BUG at fs/aufs/debug.c:425! invalid opcode: 0000 [#1] last sysfs file: /sys/devices/pci0000:00/0000:00:0f.2/device Modules linked in: xt_state ipt_MASQUERADE ipt_REJECT xt_conntrack ppp_generic ] Pid: 18, comm: aufsd/0 Tainted: P W (2.6.32-327 #4) EIP: 0060:[<c01daa5b>] EFLAGS: 00010246 CPU: 0 EIP is at au_dbg_verify_kthread+0x26/0x2c EAX: 00000000 EBX: d8644e60 ECX: ffffffff EDX: c0343740 ESI: 00000000 EDI: c01d9fbe EBP: df08fd68 ESP: df08fd68 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 Process aufsd/0 (pid: 18, ti=df08e000 task=df054060 task.ti=df08e000) Stack: df08fd78 c01c435f deabda00 d8644e60 df08fd90 c01c4436 d8644160 d8644160 <0> d8606844 d8644180 df08fdb8 c01d9a9f 40000100 dec24c24 00000004 deeaf20c <0> d8606840 40000100 d3f7933c dee8ab38 df08fdf0 c01da811 df08fdd8 d3f7933c Call Trace: [<c01c435f>] ? au_wkq_run+0xe/0x4f [<c01c4436>] ? au_wkq_nowait+0x61/0x94 [<c01d9a9f>] ? au_hnotify+0x1c5/0x21c [<c01da811>] ? au_hfsn_handle_event+0x7a/0x93 [<c0176d36>] ? fsnotify+0xa6/0xd6 [<c015d399>] ? vfs_mkdir+0x92/0x9f [<c01a6f25>] ? ubifs_mkdir+0x0/0x175 [<c01c4b71>] ? vfsub_mkdir+0x21/0x61 [<c015cc08>] ? __lookup_hash+0x40/0xe2 [<c01c604d>] ? cpup_entry+0x228/0x408 [<c015c98a>] ? path_put+0x20/0x23 [<c01c647f>] ? au_cpup_single+0x252/0x403 [<c0162e0c>] ? dput+0x1c/0xe7 [<c01c6b07>] ? au_cpup_simple+0x72/0xa7 [<c01c43a0>] ? wkq_func+0x0/0x35 [<c01c6c4e>] ? au_call_cpup_simple+0x1d/0x27 [<c01c43ac>] ? wkq_func+0xc/0x35 [<c0122c91>] ? worker_thread+0xb1/0x119 [<c01252b9>] ? autoremove_wake_function+0x0/0x33 [<c0122be0>] ? worker_thread+0x0/0x119 [<c0124fd9>] ? kthread+0x60/0x65 [<c0124f79>] ? kthread+0x0/0x65 [<c0102ed3>] ? kernel_thread_helper+0x7/0x10 Code: 9a fe ff 5d c3 55 a1 2c 5e 39 c0 f6 40 0e 20 89 e5 74 1c 05 f4 01 00 00 b EIP: [<c01daa5b>] au_dbg_verify_kthread+0x26/0x2c SS:ESP 0068:df08fd68 ---[ end trace 259ce18ddf38ea75 ]--- Kernel panic - not syncing: Fatal exception Pid: 18, comm: aufsd/0 Tainted: P D W 2.6.32-327 #4 Call Trace: [<c02e2622>] ? printk+0xf/0x15 [<c02e2572>] panic+0x39/0xda [<c0104b23>] oops_end+0x7b/0x8a [<c0104c67>] die+0x49/0x4f [<c01030eb>] do_trap+0x7d/0x85 [<c010339a>] ? do_invalid_op+0x0/0x7b [<c010340b>] do_invalid_op+0x71/0x7b [<c01daa5b>] ? au_dbg_verify_kthread+0x26/0x2c [<c01b599f>] ? dirty_cow_nnode+0x40/0xec [<c013bbb5>] ? __alloc_pages_nodemask+0xca/0x432 [<c01b8377>] ? ubifs_update_one_lp+0x75/0xa4 [<c02e3b6e>] error_code+0x5e/0x64 [<c01d9fbe>] ? au_hn_bh+0x0/0x555 [<c010339a>] ? do_invalid_op+0x0/0x7b [<c01daa5b>] ? au_dbg_verify_kthread+0x26/0x2c [<c01c435f>] au_wkq_run+0xe/0x4f [<c01c4436>] au_wkq_nowait+0x61/0x94 [<c01d9a9f>] au_hnotify+0x1c5/0x21c [<c01da811>] au_hfsn_handle_event+0x7a/0x93 [<c0176d36>] fsnotify+0xa6/0xd6 [<c015d399>] vfs_mkdir+0x92/0x9f [<c01a6f25>] ? ubifs_mkdir+0x0/0x175 [<c01c4b71>] vfsub_mkdir+0x21/0x61 [<c015cc08>] ? __lookup_hash+0x40/0xe2 [<c01c604d>] cpup_entry+0x228/0x408 [<c015c98a>] ? path_put+0x20/0x23 [<c01c647f>] au_cpup_single+0x252/0x403 [<c0162e0c>] ? dput+0x1c/0xe7 [<c01c6b07>] au_cpup_simple+0x72/0xa7 [<c01c43a0>] ? wkq_func+0x0/0x35 [<c01c6c4e>] au_call_cpup_simple+0x1d/0x27 [<c01c43ac>] wkq_func+0xc/0x35 [<c0122c91>] worker_thread+0xb1/0x119 [<c01252b9>] ? autoremove_wake_function+0x0/0x33 [<c0122be0>] ? worker_thread+0x0/0x119 [<c0124fd9>] kthread+0x60/0x65 [<c0124f79>] ? kthread+0x0/0x65 [<c0102ed3>] kernel_thread_helper+0x7/0x10 --- On Tue, Dec 7, 2010 at 7:02 PM, <sf...@users.sourceforge.net> wrote: > > Joonwoo Park: >> Thanks for providing me this patch. Patch works flawlessly. >> FYI, I did my test with patch applied aufs2.1-standalone.tree-32-20101206. > > Thank you very much. > The patch (I already made some minor changes) will be included in next > release. > > > J. R. Okajima > ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d
