aa" 2019aa^1'8ae31aeYEN 10:53i 1/4"J. R. Okajima" <hooanon...@gmail.com> aaae,:
> > "J. R. Okajima": > > I will prepare another environment and try newer gcc.A This may need > > some time.A Please be patient. > > Now I am trying with gcc-v8.3 (Debian 8.3.0-6), and I can see the > warning. > > > @@ -1499,8 +1499,10 @@ static int au_opt_br(struct super_block *sb, struct au_opt *opt, > >A if (opt->add.bindex < 0) > >A opt->add.bindex = 0; > >A goto add; > > + /* Always goto add, not fallthrough */ > >A case Opt_prepend: > >A opt->add.bindex = 0; > > + /* fallthrough */ > >A add: /* indented label */ > >A case Opt_add: > >A err = au_br_add(sb, &opt->add, > > Confirmed that this "fallthrough" comment works, ok. > But what about "Always goto add, not fallthrough" comment?A Is it > necessary?A Or you just want it to be more clear? The default level which is being used by kernel is 3 which requires a comment including kind of "fallthrough" word. I just by the way made it clear. Zhe > > > J. R. Okajima
