Hi Francis,

On Fri, 2010-10-22 at 14:09 -0400, [email protected]
wrote:
> diff --git a/src/get.c b/src/get.c
> index 11ea5de..9d420af 100644
> --- a/src/get.c
> +++ b/src/get.c
> @@ -572,6 +572,7 @@ static struct tree *get_quant_star(struct lens *lens, 
> struct state *state) {
>  
>          t = get_lens(lens->child, state);
>          list_tail_cons(tree, tail, t);
> +        list_update_tail(tree, tail);

Why is a new macro needed here ? The list_tail_cons macro should already
maintain tail as the tail of the list tree. If it doesn't, there's a bug
in it.

The reason I added list_tail_cons is that for long lists, the quadratic
behavior of walking the entire list becomes too expensive. I fear that
list_update_tail will cause a similar problem.

David


_______________________________________________
augeas-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/augeas-devel

Reply via email to