On Thu, Feb 14, 2013 at 08:26:15PM -0500, canyonknight wrote:
> On Thu, Feb 14, 2013 at 7:02 PM, Lukas Fleischer
> <archli...@cryptocrack.de> wrote:
> > Drop the (very bad) PHP parser and allow for passing all necessary
> > configuration via command line parameters.
> >
> > Also, add a convenience wrapper written in PHP that parses the
> > configuration file and subsequently calls aurblup with correct command
> > line options.
> >
> > Signed-off-by: Lukas Fleischer <archli...@cryptocrack.de>
> > ---
> [...]
> > -    if (strstr(line, CONFIG_KEY_HOST)) {
> > -      t = &mysql_host;
> > -      u = &mysql_socket;
> > -    }
> > -    else if (strstr(line, CONFIG_KEY_USER))
> > -      t = &mysql_user;
> > -    else if (strstr(line, CONFIG_KEY_PASSWD))
> > -      t = &mysql_passwd;
> > -    else if (strstr(line, CONFIG_KEY_DB))
> 
> CONFIG_KEY_* can all be removed from config.h.proto
> 
> [...]
> > -  read_config(AUR_CONFIG);
> 
> AUR_CONFIG can also be removed from config.h.proto
> 
> [...]

Good catch, thanks!

Reply via email to