On Fri, Jan 17, 2014 at 11:46:29AM +0100, Lukas Fleischer wrote:
> Make use of the "errorlist" class instead of "pkgoutput" which is no
> longer defined in the CSS.
>
> Signed-off-by: Lukas Fleischer <[email protected]>
> ---
> web/html/pkgsubmit.php | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
> index 9dba945..373af35 100644
> --- a/web/html/pkgsubmit.php
> +++ b/web/html/pkgsubmit.php
> @@ -477,10 +477,6 @@ html_header("Submit");
>
> ?>
>
> -<?php if ($error): ?>
> - <p class="pkgoutput"><?= $error ?></p>
> -<?php endif; ?>
> -
> <div class="box">
> <h2><?= __("Submit"); ?></h2>
> <p><?= __("Upload your source packages here. Create source packages
> with `mkaurball`.") ?></p>
> @@ -494,6 +490,10 @@ html_header("Submit");
> $pkg_categories = pkgCategories();
> ?>
>
> +<?php if ($error): ?>
> + <ul class="errorlist"><li><?= $error ?></li></ul>
> +<?php endif; ?>
> +
I'm not against this change, but I'll point out that this breaks burp's
error reporting (easily fixed, of course). It'd be really nice if we
could have a proper API for uploading with nicely formed responses.
> <form action="<?= get_uri('/submit/'); ?>" method="post"
> enctype="multipart/form-data">
> <fieldset>
> <div>
> --
> 1.8.5.3
>
