On Wed, Sep 25, 2019 at 10:30:05PM +0000, kpcyrd wrote:
> On Fri, Sep 20, 2019 at 10:21:42PM -0400, Daniel M. Capella via aur-general
> wrote:
> > Package review:
> >
> > narnia, tr1pd{,-git}: Could use `--locked`?
> >
> > python-fints: Missing `--skip-build` in `package()`.
>
> Thanks, I've pushed updates for these a few days ago.
>
> > Only nit I have aside from those is you don't need to specify 755
> > permissions for `install` as that's the default. Something I learned
> > during my own Tu application process ^^.
>
> Interesting, didn't know that! I'm going to roll out fixes for that
> incrementally, thanks for pointing it out.... but there's nothing wrong with keeping 755 either, as it makes excplicitely clear to the reader which permissions are used for the binary. Alad
signature.asc
Description: PGP signature
