On Wed, 21 Dec 2022 22:38:29 +0300 Greg Minshall <[email protected]> wrote:
> hi. i'm trying to submit my first package to AUR. my package files are > here: > ---- > https://git.sr.ht/~minshall/aur-orgtbl-query/tree > ---- > > if anyone has a chance to look over my PKGBUILD (and any other of the > files), and has any comments, i'm all ears. > > cheers, Greg The only real issue I see is using $pkgdir in the build function. It's not well defined at that point, and should not be relied on. Using that as a prefix doesn't really make sense anyway, prefix is for the install location, such as /usr/ or /opt/$pkgname/. Other than that, some simplification: Lines 44 and 49-53 can all be replaced by just install -Dm644 LICENSE -t "${pkgdir}/usr/share/licenses/${pkgname}/" You should remove empty functions (prepare) and variables (checkdepends and md5sums) All of the other files, (LICENSE, Makefile, README.*) are extraneous and aren't really going to do anything in the AUR. I didn't try building it, but overall, it looks good! Doug
