On 2026-08-27 01:57, Jochums Johannes wrote:
Hi everyone,I just spent my evening creating my first package, because the package in the AUR is broken, this more for the love of the game and trying something new. Then I noticed AUR registrations are currently closed. I'm more looking for some feedback, tips and suggestionshttps://github.com/infernoid/zork1-r88 <https://github.com/infernoid/ zork1-r88>Thank you
Hi, Congrats on your first package! However, a few things to note:Creating duplicate packages in the AUR is not allowed, not even to fix a broken package. Instead, get in contact with the maintainer of the current package, and propose your changes. If they are unresponsive, you can submit an orphan request (but the current maintainer maintains it since at least 10 years, and has answered timely to the last few comments, so that shouldn’t be needed)
But: the current package doesn’t seem to be broken, I could build, install and start it just fine.
And a few comments about the PKGBUILD:The name/pkgver does not make sense. The pkgver is the version of the upstream release, and normally you’d download the files for that version. But of course, this is a special case.
> depends=('frotz-ncurses')
> base_src_url="https://eblong.com";
> maps_src_url="http://infocom.elsewhere.org";
> source=(${base_src_url}/infocom/gamefiles/${pkgname}-s840726.z3
Custom variables should only be introduced when needed, and be prefixed
by an underscore (_). Otherwise they could collide with variables from
makepkg.
> license=('MIT')
The current AUR package installs a EULA. Unless the game is really under
MIT, you can’t just change the license.
And a nit: I think keeping the install commands to one line makes them much more readable than breaking them over multiple. They even fit into 80 chars.
Best, Jonathan
OpenPGP_signature.asc
Description: OpenPGP digital signature
