Hi Noah, * Noah Misch wrote on Wed, Apr 05, 2006 at 10:10:40PM CEST: > On Sun, Apr 02, 2006 at 06:36:58PM +0200, Ralf Wildenhues wrote: > > > Thanks. I guess it's ok to install. It still doesn't work with OpenBSD > > make though; I think it's because it does not check again that the > > stamp-tgat time is not updated after its rule is executed: > > This could be same problem affecting FreeBSD make.
Yes. > I substantially rewrote the patch. It's much simpler now, and the > optimization > works with GNU, FreeBSD, NetBSD, Tru64, and HP-UX Make programs. It's broken > with respect to parallel make, but that's nothing new. Works with OpenBSD 'make' as well. > We now trigger the TESTSUITE_GENERATED_AT update from check-local, so `make -C > tests ./testsuite' may build a testsuite using out-of-date tests/ac*.at. I > couldn't find a way around this without introducing more serious flaws. Hmm. I personally either do a make check TESTSUITEFLAGS=.. (where .. == -V helps for just rebuilding), or a cd tests && ./testsuite ... anyway, so it would not break my usage patterns. > What do you think? I think this patch is good, technically. But I fully understand sentiments against it, so if Paul says no, I'm happy either way. Cheers, Ralf > 2006-04-05 Noah Misch <[EMAIL PROTECTED]> > > Do not rebuild `testsuite' when a lib/autoconf/*.m4 edit does not affect > the generated test cases. > > * tests/Makefile.am (stamp_tgat): New macro. Distribute. > (check_local): Depend on $(stamp_tgat). > (check_tgat): New macro, from old TESTSUITE_GENERATED_AT commands. > (stamp_tgat): New rule. > (TESTSUITE_GENERATED_AT): Remove prerequisites. > * tests/mktests: Only touch the products if they would change. > * tests/.cvsignore: Update.
