Paolo Bonzini <[EMAIL PROTECTED]> writes:

> +[test -n "$at_traceon" && at_check_newline "AS_ESCAPE([$1], [`\"])"])])[]dnl

One minor thing: at_check_newline is trace-specific (it doesn't merely
check newlines; it does other stuff).  So we might as well migrate the
"test -n" business into at_check_newline, no?  It'll make the code
shorter and easier to read.  And perhaps its name could be changed to
"at_check_traceable" or something like that.

Other than that, it looks fine.  Please check it in, even if you
disagree with my minor advice.  And thanks.


Reply via email to