-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/9/2009 1:12 PM:
> rehashing the discussion here:
> <http://thread.gmane.org/gmane.comp.gcc.devel/108348/focus=108368>
> 
> * Eric Blake wrote on Mon, Aug 31, 2009 at 01:36:07PM CEST:
>> True.  I guess I'll find time to visit this patch, if no one beats me to it.
> 
> Lemme try to beat you to it.  It seems that that a sweep over the
> documentation to remove ',' as sed 's' separator was not necessary,
> since we used constant regular expression strings mostly (as opposed
> to expanded shell variables containing files names or so).
> 
> So I think this should document things appropriately.  Any further
> comments before I apply (tomorrow or so) and add Dave to THANKS
> (which email address should I use)?
> 
> -...@command{sed} rejects @samp{s/[^/]*$//}: use @samp{s,[^/]*$,,}.
> +...@command{sed} rejects @samp{s/[^/]*$//}: use @samp{s%[^/]*$%%}.
> +Even escaped, patterns should not include separators that are also used

s/Even escaped/Even when escaped/

> +as @command{sed} metacharacters.  For example, GNU sed 4.0.9 rejects
> +...@samp{s,x...@{1\,\...@},,}, while sed 4.1 strips the backslash before the 
> comma
> +before evaluating the basic regular expression.

Let others have a chance to reply, but I'm okay with the patch with just
that change.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             e...@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqoVdUACgkQ84KuGfSFAYAhWwCgiQ1h6VWYSVVNwW0T0eSVGB6n
lcsAnRBH5csMAVKZxWjzl20ZIojM8wWA
=vGTz
-----END PGP SIGNATURE-----


Reply via email to