On 07/20/2010 07:18 AM, Eric Blake wrote: > On 07/20/2010 01:26 AM, Paolo Bonzini wrote: >> On 07/20/2010 12:16 AM, Eric Blake wrote: >>> At this point, I'm thinking of using AS_LITERAL_HEREDOC_IF plus one >>> additional check for "; all other uses of AC_PACKAGE_STRING and friends >>> appeared to be inside "", so it's just a documentation matter to mention >>> that these strings should be double-quoted for project-generic code >>> (such as automake), but an individual project that follows stricter >>> rules (such as coreutils version string always being a single shell >>> word) can get by with referencing AC_PACKAGE_VERSION outside double >>> quotes. >> >> Considering Automake does >> >> AC_SUBST([VERSION], ['AC_PACKAGE_VERSION'])]) >> >> I think that's fine, but since you are at it you should also check for >> single quotes. > > Good point; patch for that coming up shortly.
Hmm, in thinking about it, rejecting newline would also be useful, for catching bad uses of m4_esyscmd that accidentally left a trailing newline in a version string (that has come up in mailing list traffic several times). I'll respin my patch to catch that, too. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
