On 9/22/20 1:04 PM, Zack Weinberg wrote:
The main thing I want to discuss before merging these patches is the location of the new Perl function merge_WARNINGS. I put it in ChannelDefs.pm because that is where all the other code relating to WARNINGS is, but it’s only used in autoreconf, so there’s an argument for putting it in autoreconf instead, if only so we can modify it in the future without having to go through automake.
I mildly prefer the way you did it. Thanks for looking into this.