On Fri, 4 Feb 2005, Chris Feist wrote:

> I'm working on a patch to get the get_best_mounts function (in 
> modules/mount_nfs.c) work a little better and handle a few end cases.
> 
> What was the skiplocal variable intended to do?
> 
> It seems that if it is not 0, the only thing that get_best_mount does is 
> check and see if the 'what' string is null & if it isn't return 0.  And 
> the only time the get_best_mounts function is called with skiplocal set 
> to 1. is when it is calling itself when all the hosts have not responded 
> within 100ms.
> 
> Is it reasonable to completely remove this variable?
> 

Looking at the routine I've made a bit of a mess.
I doesn't do quite what I thought I made it do. Never mind.

I don't think that skiplocal should be removed as it should determine 
whether a check to see if the host is equivalent to localhost is done.

I'm still trying to decide, but I think that the skiplocal test in the 
early part of get_best_mount should be removed.

_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs

Reply via email to