Ian Kent <[EMAIL PROTECTED]> writes: > On Mon, 2008-11-03 at 11:32 +0900, Ian Kent wrote: >> Hi all, >> >> Stef Bon has reported some difficulty with the current auto.smb. >> >> I have made a patch which demonstrates the change he is recommending and >> would like comments from others that use CIFS mounts. >> >> To quote Stef, from his previous mail: >> >> "Well, the script does (in my network) work with cifs shares, where the >> original auto.smb doesn't. In my case I have to add the ipaddress or it >> does not work. The manpage of mount.cifs says that this option has to be >> used rarely. But it's my experience sometimes when mounting a Win2K or >> WinXP machine, it does not work. >> (CIFS expects the tcp name and not the netbiosname, smbfs did that) >> >> So I cannot say it's a really "must", but at least it cannot "hurt". >> You're on the safe side when using the ipaddress." >> >> Can we have some comments on the patch below please (including you Stef, >> since I've modified you change a bit). >> >> Ian > > Sorry, the patch was not quite right. > > autofs-5.0.3 - CIFS use ip address > > From: Stef Bon <[EMAIL PROTECTED]> > > It has been reported that, for a CIFS mount, in some cases the ip > address of the server is needed otherwise the mount can fail. > --- > > samples/auto.smb | 26 +++++++++++++++++++++++++- > 1 files changed, 25 insertions(+), 1 deletions(-) > > > diff --git a/samples/auto.smb b/samples/auto.smb > index fb39053..7bec126 100755 > --- a/samples/auto.smb > +++ b/samples/auto.smb > @@ -3,7 +3,31 @@ > # This file must be executable to work! chmod 755! > > key="$1" > -opts="-fstype=cifs" > + > +FILESYSTEM="cifs" > +
So, umm, when is $FILESYSTEM not going to be cifs? > +if [ "$FILESYSTEM" != "cifs" ]; then > + opts="-fstype=$FILESYSTEM,guest" > +else > + for P in /bin /sbin /usr/bin /usr/sbin > + do > + if [ -x $P/nmblookup ]; then > + NMBLOOKUP=$P/nmblookup > + break > + fi > + done > + > + if [ ! -x "$NMBLOOKUP" ]; then > + exit 1 > + fi Is it possible to not have the nmblookup program? It seems to me it would be safer to at least try the mount w/o the ip address if you can't obtain one. > + > + ipaddress=$($NMBLOOKUP $key --debug-level=0 2>>/dev/null | grep '<00>' > | awk '{ print $1 }') > + if [ -z "$ipaddress" ]; then > + exit 1 > + fi > + > + opts="-fstype=cifs,guest,ip=$ipaddress" > +fi > > for P in /bin /sbin /usr/bin /usr/sbin > do Can we compress these two loops that do the same thing (determine the path to the samba/cifs binaries)? Cheers, Jeff _______________________________________________ autofs mailing list autofs@linux.kernel.org http://linux.kernel.org/mailman/listinfo/autofs