On Wed, 2009-01-21 at 16:15 +1100, Paul Wankadia wrote: > On Wed, Jan 21, 2009 at 2:49 PM, Ian Kent <ra...@themaw.net> wrote: > > Fortunately, these cases usually don't happen so we haven't > seen a > problem with it already. > > Anyway, i think this is all we need although continuing after > an malloc > fail is a bit questionable. Suggestions? > > In this case, make_fullpath() is called from only one place and its > return value is checked, but I was asking in general, yes.
Not sure I understand the question. Functions like make_fullpath() need to return a NULL in such a case because it has to be up to the caller to decide on how to handle the fail. In the case above it is questionable whether we continue the prune but then another thread could free() heap memory so we might still be able to make some useful progress. Ian _______________________________________________ autofs mailing list autofs@linux.kernel.org http://linux.kernel.org/mailman/listinfo/autofs
