* Stefano Lattarini wrote on Mon, Apr 26, 2010 at 12:15:33AM CEST:
> --- a/tests/silent6.test
> +++ b/tests/silent6.test

> @@ -99,5 +99,3 @@ $AUTOMAKE
>  grep 'AM_V_GEN' Makefile.in
>  $AUTOMAKE --force -Wno-all -Wportability
>  grep 'AM_V_GEN' Makefile.in
> -
> -:

Please don't remove trailing ':' or 'Exit 0'.  They exist for a reason:
when somebody changes the test by adding a failing command after the
last command, the test will spuriously fail because $? is nonzero at the
end.  Keeping a trailing ':' prevents that.  (And no, please also don't
newly introduce these things just for the heck of it either (i.e., when
you wouldn't otherwise be editing the test), that's not the point.)

Thanks,
Ralf


Reply via email to