At Tuesday 08 June 2010, Ralf Wildenhues <ralf.wildenh...@gmx.de>
wrote:
> > -$ACLOCAL > output 2>&1 || { cat output; Exit 1; }
> > -test -z "`cat output`"
> > +$ACLOCAL >output 2>&1 || { cat output; Exit 1; }
>
> Do you do these changes with a script?
No, since (as you pointed out many times), the use of `errexit'
shellflag can cause portability problems if not done carefully.
So I prefer manual editing and (more or less) careful visual
inspection.
> If not, then why such whitespace changes?
Mostly absent-mindness.
> It's not like there is any consistency in
> spacing there in the current code.
Definitely right :-)
> (I'm asking because I actually had to look three times to ensure
> I didn't overlook a non-whitespace change.)
Yes, that might be pretty annoying, and might end up making review
more difficult. I'll try to be more careful in the future.
Thanks,
Stefano
