Hi Stefano, * Stefano Lattarini wrote on Sat, May 08, 2010 at 01:46:46AM CEST: > This seems huge, but most changes are trivial and/or similar. > And having all these tweakings packed in a big lump should make their > reviewing easier IMHO (at least, it shouldn't make it more difficult).
> Modernize, improve and/or fix various test scripts. > > * tests/sanity.test: Rely on the `configure.in' stub created by > `./defs', rather than writing one from scratch. > * tests/depend2.test: Likewise. Also, call `set -e' just after > the inclusion of `./defs', instead that later in the script. > * tests/canon5.test: Avoid a useless `|| Exit 1' after a call to > $AUTOMAKE, and improve the positioning of an $ACLOCAL call. > * tests/exeext4.test: Use $FGREP instead of grep, where possible. > Make auxiliary rules in the generated Makefile more silent. > These changes make some checks slighty stricter. > * tests/ext2.test: Call `Exit 1' if inclusion of `./defs' fails. > * tests/gettext2.test: Place final `:' at the end of the script, > rather than in the middle. > * tests/exeext.test: Call `set -e' just after the inclusion of > `./defs', instead that later in the script. > * tests/extra5.test: Likewise. > * tests/confdeps.test: Likewise. Also, prefer `mv -f' over > plain `mv', just to be sure. > * tests/depcomp.test: Enable `errexit' shell flag, with related > changes. Also, modernize the generated configure.in. > * tests/cond9.test: Likewise. Also, rely on the `configure.in' > stub created by `./defs', rather than writing one from scratch. > * tests/cond10.test: Likewise. > * tests/depcomp2.test: Likewise. > * tests/depend3.test: Likewise. > * tests/distcom7.test: Likewise. > * tests/fortdep.test: Likewise. Also, remove definition of > AUTOMAKE_OPTIONS to `foreign' in the generated Makefile.am, > since that flag is already provided by $AUTOMAKE. > * tests/mdate.test: Made stricter, by checking that Automake > actually failed, and by making a stricter grep on the error > message. Also, set shell `errexit flag'. > * tests/python2.test: Improved verbose messages. Thanks! For maint, with this shamelessly squashed in. Cheers, Ralf diff --git a/tests/sanity.test b/tests/sanity.test index 8416976..ed7fe28 100755 --- a/tests/sanity.test +++ b/tests/sanity.test @@ -32,14 +32,14 @@ $ACLOCAL $AUTOCONF $AUTOMAKE ./configure 2>stderr && { cat stderr >&2; Exit 1; } -cat stderr +cat stderr >&2 grep 'unsafe absolute working directory' stderr cd .. mkdir build cd build ../unsafe$/configure 2>stderr && { cat stderr >&2; Exit 1; } -cat stderr +cat stderr >&2 grep 'unsafe srcdir' stderr :