At Sunday 04 July 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Fri, Jul 02, 2010 at 05:23:36PM CEST: > > OK, this should have really been the first patch in the series, > > so let's review it first. > > > but I > > didn't think of it until the series was almost finished, and at > > that point I dind't want to risk a rebase with a lot of annoying > > conflicts (almost all of them spurious, BTW). No big deal IMHO. > > > > Make sure all tests needing gzip require it explicitly. > > Why? Because there are some tests which explicitly put "gzip" in $required: $ grep '^required=.*gzip.*' tests/*.test tests/install2.test:required=gzip tests/lex3.test:required='gcc gzip flex GNUmake' tests/pr9.test:required=gzip
> Did we get a bug report about a system without gzip > installed? No. And in such a case, I'd have probably answered with a "please fix your system" suggestion :-) > IMVHO we can just require gzip to be present, just like > sed, tar, and most of the other commands listed in the GNU Coding > Standards. In hindsight, I agree. Maybe I'll subtitute this patch with a new one which removes "gzip" from $required in the three tests above; but this is low priority. > > Am I missing something? No, it was me who was missing something :-) Regards, Stefano
