At Sunday 08 August 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST: > > * tests/asm.test: Use configure.in stub generated by ./defs, > > and avoid obsoleted autoconf constructs. Make grepping of > > Automake stderr stricter. Do not create useless source file. > > Improve verbose messages. Minor cosmetic changes. Tell to > > keep it in sync with other sister tests asm*.test. > > * tests/asm2.test: Likewise. > > * tests/asm3.test: Likewise. > > OK with nits below addressed. > > Thanks, > Ralf > > > --- a/tests/asm.test > > +++ b/tests/asm.test > > > > +echo '*** Run 1 -- Should fail because we need CC and CCAS ***' > > s/Run/Try/? Ok. Substituted consistently in all asm*.test scripts. > s/Should/should/ ? Tsk ;-) But I did the substitution, it seems technically more correct. Likewise for similar capitalizations in all asm*.test scripts.
> > +echo '*** Run 4 -- We have every needed, expect a success ***' > > s/every/&thing/ several instances in the patch > s/ a / / Fixed. > > --- a/tests/asm2.test > > +++ b/tests/asm2.test > > > > AUTOMAKE_fails > > > > -grep AM_PROG_AS stderr > > +grep 'define .*am__fastdepCCAS.* add .*AM_PROG_AS' stderr > > I prefer not grepping for internal details like am__fastdepCCAS. > More than one instance in the patch. Fixed, using this instead: grep ' add .*AM_PROG_AS' stderr Regards, Stefano