Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 03:07:30PM CEST:
> I noticed some problems (both serious and cosmetic) in your patch.
> Here is a summary of the in decreasing order of relevance:
>
> 1. You sometimes failed to use `$MAKE' instead of `make' and `Exit'
> instead of `exit' ("make maintainer-check" cuaght this).
> 2. IMHO it's better to avoid redirecting output (from e.g. grep and
> cmp) to /dev/null, since our testsuite is already very verbose, and
> some extra output (even if redundant) won't hurt.
> 3. tests/README suggest to end test scripts with a `:':
> ``End the test script with a `:' or `Exit 0'. Otherwise, when
> somebody changes the test by adding a failing command after
> the last command, the test will spuriously fail because $? is
> nonzero at the end.''
> 4. Ralf and I agreed that we shouldn't put `gzip' in $required, since
> it's a basic tool to be taken for granted (like e.g. diff and sed
> are).
> 5. Some minor blemishes, inconsistencies, and cosmetic stuff.
>
> Also, you forgot to make new tests executable, and to add them to
> $(TESTS) in tests/Makefile.am.
>
> OK to push the three attached follow-up patches?
These three patches plus the squash-in followup all look fine to me.
Give Bruno some time for comments before applying to the pot-primary
branch, please.
Thanks,
Ralf
