* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 08:23:30PM CET: > On Saturday 06 November 2010, Stefano Lattarini wrote: > > On Saturday 06 November 2010, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 05:52:57PM CET: > > > > Hi Ralf, I've just spotted a bug in the patch ... [...] > > > > ... here (missing "fi"). It causes a failure in `vala2.test'. > > > > > > > > I'll install a fix later if you don't beat me (right now I'm doing other > > > > testing, and prefer not to be sidetracked by this issue). > > > > > > That's what I get for forgetting one testsuite addition. Thanks for > > > tracking this down, and please push the fix, ideally together with a > > > new test > > Is a new test really needed? After all, I noticed the bug because it > > broke the pre-existing `vala2.test'...
Ouch. That means I either messed up testing somehow, or pushed an old version of the patch. Probably the latter, as I remember fixing a vala related bug. > I've gone ahead and comitted the fix without adding a new testcase. > Please let me know if you still think a testcase addition would be > valuable, in which case I'll add it in a follow-up patch. No, in that case it is fine as is. Thanks. Cheers, Ralf
