Hello Stefano, * Stefano Lattarini wrote on Mon, Sep 20, 2010 at 11:08:34PM CEST: > This patch increase coverage for a macro I'm planning to touch > soon (to make it use AS_HELP_STRING). OK for maint?
Does *anybody* use AM_WITH_REGEX? Have you checked? This seems so obsoleted by gnulib that I don't think it is worth investing any more time into. > More tests on macro `AM_WITH_REGEX'. > > * tests/regex.test: Extend with more configure runs. Add > trailing `:' command. > * tests/regex2.test: New test. > * tests/regex3.test: Likewise. > * tests/Makefile.am (TESTS): Updated > --- a/tests/regex.test > +++ b/tests/regex.test > @@ -15,6 +15,7 @@ > # along with this program. If not, see <http://www.gnu.org/licenses/>. > > # Make sure AM_WITH_REGEX compiles and runs. > +# See also related tests `regex2.test' and `regex3.test' > > . ./defs || Exit 1 > > @@ -28,3 +29,8 @@ $ACLOCAL > $AUTOCONF > ./configure > ./configure --without-regex > +./configure --with-regex > +./configure --with-regex=no > +./configure --with-regex=yes But what do these new lines bring us in terms of coverage, except wasted time? The AC_ARG_WITH macro is tested in Autoconf already. > --- /dev/null > +++ b/tests/regex2.test > +# Make sure AM_WITH_REGEX compiles and runs as advertised in > +# documentation. > +# See also sister test `regex3.test' Both of these tests seem so low-level, and yet so unlike what any user code would do, that I don't really see how they help the code. IOW, I fail to see how they ensure that the macro is actually useful for some package. Thanks, Ralf