* tests/defs ($priv_check_temp, $overwrite_status, $ro_dir_temp, $create_status, $r2h, $libtool_found, $gettext_found, $aclocaldir, $extra_includes): Unset once they've served their purpose. --- ChangeLog | 7 +++++++ tests/defs | 5 +++++ 2 files changed, 12 insertions(+), 0 deletions(-)
From cadeda85ac9c55bee84a280ee1bfdb4e5ce78479 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Fri, 12 Nov 2010 14:52:51 +0100 Subject: [PATCH 1/5] Tests defs: don't let useless variables leak in test scripts.
* tests/defs ($priv_check_temp, $overwrite_status, $ro_dir_temp, $create_status, $r2h, $libtool_found, $gettext_found, $aclocaldir, $extra_includes): Unset once they've served their purpose. --- ChangeLog | 7 +++++++ tests/defs | 5 +++++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 634a3ed..8c5bf41 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-11-12 Stefano Lattarini <stefano.lattar...@gmail.com> + + Tests defs: don't let useless variables leak in test scripts. + * tests/defs ($priv_check_temp, $overwrite_status, $ro_dir_temp, + $create_status, $r2h, $libtool_found, $gettext_found, $aclocaldir, + $extra_includes): Unset once they've served their purpose. + 2010-11-11 Stefano Lattarini <stefano.lattar...@gmail.com> Tests defs: improve messages for skipped tests. diff --git a/tests/defs b/tests/defs index 82c3b5b..e5f54ba 100644 --- a/tests/defs +++ b/tests/defs @@ -233,6 +233,7 @@ do echo "$me: cannot drop file write permissions" >&2 exit 77 fi + unset priv_check_temp overwrite_status ;; perl-threads) if test "$WANT_NO_THREADS" = "yes"; then @@ -258,6 +259,7 @@ do echo "$me: cannot drop directory write permissions" >&2 exit 77 fi + unset ro_dir_temp create_status ;; rst2html) # Try the variants that are tried in check.am. @@ -269,6 +271,7 @@ do echo "$me: no proper rst2html program found" >&2 exit 77 done + unset r2h ;; runtest) # DejaGnu's runtest program. We rely on being able to specify @@ -375,6 +378,8 @@ case " $required " in ;; esac ACLOCAL="$ACLOCAL -Wno-syntax -I $top_testsrcdir/m4 $extra_includes -I $aclocaldir" + unset libtool_found gettext_found + unset extra_includes aclocaldir ;; esac -- 1.7.1