* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: > * tests/defs: In the loop on "$required" tools: avoid subshells > where not neded.
OK except for the last hunk: > --- a/tests/defs > +++ b/tests/defs > @@ -297,12 +297,12 @@ do > *) > # Generic case: the tool must support --version. > echo "$me: running $tool --version" > - ( $tool --version ) || exit 77 > + $tool --version || exit 77 It is not likely but possible that $tool is a special builtin, in which case the shell is allowed to exit after an error. Please leave the subshell here. > ;; > esac > done Thanks, Ralf
