* Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET: > More checks on warnings/strictness in precedence ("metawarnings").
metawarnings is not a proper word, how about just eliding the part in parentheses? Yes, I know I'm probably too picky on language; if it starts bothering you, I'll offer more beer when we should meet. ;-) > * tests/metawarnings-win-over-strictness.test: New test, similar > to `warnings-win-over-strictness.test', but with the explicit > warning levels being "meta-warnings" (like `-Wall' and `-Wnone'). How about s/the explicit ...(\(.*\))/catch-all warning flags \1/ and just naming the test warning-groups-win-over-strictness.test? > * tests/Makefile.am (TESTS): Update. > --- /dev/null > +++ b/tests/metawarnings-win-over-strictness.test > +# Check that, on the command line, explicitly-defined warning levels take > +# precedence over implicit strictness-implied warnings, even when these > +# explicit warning levels are "meta-warnings" (as `-Wall' and `-Wnone'). see above > +# Since we are at it, throw in also *.am and *.m4 file inclusions. also throw in > +cat > configure.in << END > +AC_INIT([$me], [1.0]) > +m4_include([am-init-automake.m4]) > +AC_PROG_CC > +AC_CONFIG_FILES([Makefile]) > +# Other similar tests do not use AC_OUTPUT, so we use it here, > +# for completness and for better coverage. completeness > +AC_OUTPUT > +END > + > +cat > Makefile.am <<END > +include automake-options.am > +FOO := bar > +END > + > +: > automake-options.am > +echo 'AM_INIT_AUTOMAKE' > am-init-automake.m4 double space I'm not sure it works to put AM_INIT_AUTOMAKE in an included macro. We definitely have places in autotools somewhere that grep for it, but I don't know if any of those are relevant here. > +$ACLOCAL --force > +AUTOMAKE_fails -Werror -Wall --foreign > +grep '^Makefile\.am:.*:=.*not portable' stderr $sleep or remove autom4te.cache here. > +: > automake-options.am > +echo 'AM_INIT_AUTOMAKE([-Werror -Wnone gnu])' > am-init-automake.m4 > +$ACLOCAL --force > +$AUTOMAKE Likewise here. You are not using command-line options here. Is that intended? If not, then it seems like the test description does not fully match the action. > +echo 'AUTOMAKE_OPTIONS = -Werror -Wnone gnits' > automake-options.am > +echo 'AM_INIT_AUTOMAKE' > am-init-automake.m4 > +$ACLOCAL --force > +$AUTOMAKE trailing white space. OK with that addressed. Thanks, Ralf