Hi Ralf.

I've (basically) addressed all your nits, and pushed to yacc-work.

Just one nit on my part ...

> > +# Check that the expected non-generic rules has been truly generated.
> 
> truly have been generated.
> 
> > +# Otherwise, the coverage offered by this test will be weaker then
> > +# expected and planned.
> 
> s/and planned// ?
> 
Hadn't we agreed to use a short sentence here?  You suggested:
  # Ensure per-target rules are used, to ensure their coverage below.
and I went with that.

> > +$FGREP 'bar-parse.c' Makefile.in
> > +$FGREP '$(bar_YFLAGS)' Makefile.in
> [...]
> 

Thanks,
  Stefano

Reply via email to