Hello automakers. The tests `lflags.test' and `lflags2.test' fail if an environment variable LEX is defined, because they call `make -e', thus letting the value of that variable override the value we forced at configure time. This bug is the the same already discovered in yflags*.test (and fixed in previous commit v1.11-137-gc876b0e). The attached patch fixes it.
OK for a temporary branch 'lflags-test-fixes' (stemming out of commit v1.11-136-gfee7d0d "Fix minor testsuite issues, update docs, for Yacc/Lex changes"), to be merged into maint and yacc-work? Regards, Stefano
From 57198decf1d0dfa758d70ac564e2aec4281798d0 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Sat, 29 Jan 2011 18:35:45 +0100 Subject: [PATCH] tests: fix spurious failures in lflags*.test * tests/lflags.test: Remove 'LEX' from the environment, so that it won't be erroneously picked up by `make -e'. * tests/lflags2.test: Likewise. --- ChangeLog | 7 +++++++ tests/lflags.test | 4 ++++ tests/lflags2.test | 4 ++++ 3 files changed, 15 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 98e5792..b0c6f16 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-01-29 Stefano Lattarini <stefano.lattar...@gmail.com> + + tests: fix spurious failures in lflags*.test + * tests/lflags.test: Remove 'LEX' from the environment, so + that it won't be erroneously picked up by `make -e'. + * tests/lflags2.test: Likewise. + 2010-06-21 Ralf Wildenhues <ralf.wildenh...@gmx.de> Fix minor testsuite issues, update docs, for Yacc/Lex changes. diff --git a/tests/lflags.test b/tests/lflags.test index 97de608..4c3e048 100755 --- a/tests/lflags.test +++ b/tests/lflags.test @@ -30,6 +30,10 @@ echo 'extern int dummy;' >> lex.yy.c END chmod a+x fake-lex +# Remove Lex from the environment, so that it won't interfere +# with `make -e' below. +unset LEX || : + cat >> configure.in <<'END' AC_PROG_CC # Simulate presence of Lex using our fake-lex script. diff --git a/tests/lflags2.test b/tests/lflags2.test index df766b2..f13c656 100755 --- a/tests/lflags2.test +++ b/tests/lflags2.test @@ -31,6 +31,10 @@ echo 'extern int dummy;' >> lex.yy.c END chmod a+x fake-lex +# Remove Lex from the environment, so that it won't interfere +# with `make -e' below. +unset LEX || : + cat >> configure.in <<'END' AC_PROG_CXX # Simulate presence of Lex using our fake-lex script. -- 1.7.2.3
