* Stefano Lattarini wrote on Sun, Feb 13, 2011 at 02:09:03PM CET: > On Sunday 13 February 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Feb 13, 2011 at 11:49:28AM CET: > > > + cat pythondir > > > + case `cat pythondir` in '$${prefix}'/*);; *) exit 1;; esac > > > + cat pyexecdir > > > + case `cat pyexecdir` in '$${exec_prefix}'/*);; *) exit 1;; esac > > > > This is probably pragmatically correct most anywhere, but I don't think > > we require pyexecdir to start with ${exec_prefix}. The user can > > override it, for example by a cache variable entry in config.site, no? > > > Yes, but than he could do so also for `pythondir' -- which would cause > failures in both `python-vars.test' and `python-virtualenv.test'. Maybe > the best fix would be to `export CONFIG_SITE=/dev/null' in these tests?
OK. That is, 'CONFIG_SITE=/dev/null; export CONFIG_SITE' of course. > Or should we start caring about those cache variables only once (and if) > they start creating real troubles? However you like. Since we've determined this test to be potentially problematic already, we can address it now and stop worrying. > > Tests should generally be lax wrt. sane config.site entries. When we > > meet insane ones, we may want to decide to disable it for our testsuite, > > but let's cross that bridge when we get to it. > Also, as an aside, now that $pyvars does not contain anymore `pythondir' > and `pyexecdir', I think we should also squash-in the following diff in > the test. OK? Sure, why not. Thanks, Ralf > --- a/tests/python-vars.test > +++ b/tests/python-vars.test > @@ -93,7 +93,7 @@ cat vars-got.in > $ACLOCAL > $AUTOMAKE --add-missing > > -for var in $pyvars; do > +for var in pythondir pyexecdir $pyvars; do > grep "^$var *=" Makefile.in > done