The sleeps were there to make generated autotools files strictly newer than their sources; however, this is not necessary, since POSIX mandates that make considers files with the same timestamp of their dependencies to be up-to-date.
* tests/remake9a.test: Remove useless $sleep. * tests/remake9b.test: Likewise. * tests/remake9c.test: Likewise. * tests/remake9d.test: Likewise. * tests/remake10a.test: Likewise. * tests/remake10b.test: Likewise. * tests/remake10c.test: Likewise. --- OK for master? I will push in 72 hours if there is no objection. Regards, Stefano
From d8e55f890fda53b2e1fb3cdc6510838ab1477f29 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Sun, 3 Apr 2011 10:19:24 +0200 Subject: [PATCH] tests: remove useless sleep from tests on remake rules The sleeps were there to make generated autotools files strictly newer than their sources; however, this is not necessary, since POSIX mandates that make considers files with the same timestamp of their dependencies to be up-to-date. * tests/remake9a.test: Remove useless $sleep. * tests/remake9b.test: Likewise. * tests/remake9c.test: Likewise. * tests/remake9d.test: Likewise. * tests/remake10a.test: Likewise. * tests/remake10b.test: Likewise. * tests/remake10c.test: Likewise. --- ChangeLog | 15 +++++++++++++++ tests/remake10a.test | 1 - tests/remake10b.test | 1 - tests/remake10c.test | 1 - tests/remake9a.test | 1 - tests/remake9b.test | 1 - tests/remake9c.test | 1 - tests/remake9d.test | 1 - 8 files changed, 15 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index d8750df..040df24 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2011-04-03 Stefano Lattarini <stefano.lattar...@gmail.com> + + tests: remove useless sleep from tests on remake rules + The sleeps were there to make generated autotools files strictly + newer than their sources; however, this is not necessary, since + POSIX mandates that make considers files with the same timestamp + of their dependencies to be up-to-date. + * tests/remake9a.test: Remove useless $sleep. + * tests/remake9b.test: Likewise. + * tests/remake9c.test: Likewise. + * tests/remake9d.test: Likewise. + * tests/remake10a.test: Likewise. + * tests/remake10b.test: Likewise. + * tests/remake10c.test: Likewise. + 2011-04-02 Stefano Lattarini <stefano.lattar...@gmail.com> tests: fix timestamp-related failures diff --git a/tests/remake10a.test b/tests/remake10a.test index 7da457c..91e9449 100755 --- a/tests/remake10a.test +++ b/tests/remake10a.test @@ -43,7 +43,6 @@ END echo 'm4_define([my_fingerprint], [BadBadBad])' > foo.m4 -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL $AUTOCONF $AUTOMAKE diff --git a/tests/remake10b.test b/tests/remake10b.test index 0672fc9..50113c8 100755 --- a/tests/remake10b.test +++ b/tests/remake10b.test @@ -42,7 +42,6 @@ END echo 'FINGERPRINT = BadBadBad' > foo.am -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL $AUTOCONF $AUTOMAKE diff --git a/tests/remake10c.test b/tests/remake10c.test index 9b9aca9..9caf9da 100755 --- a/tests/remake10c.test +++ b/tests/remake10c.test @@ -45,7 +45,6 @@ END mkdir m4 echo 'AC_DEFUN([my_fingerprint], [BadBadBad])' > m4/foo.m4 -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL -I m4 $AUTOCONF $AUTOMAKE diff --git a/tests/remake9a.test b/tests/remake9a.test index d46f317..1358ad0 100755 --- a/tests/remake9a.test +++ b/tests/remake9a.test @@ -52,7 +52,6 @@ END echo cat > tweak-configure-in # no-op by default -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL $AUTOCONF $AUTOMAKE diff --git a/tests/remake9b.test b/tests/remake9b.test index 680ce9a..364bcbe 100755 --- a/tests/remake9b.test +++ b/tests/remake9b.test @@ -54,7 +54,6 @@ END echo cat > tweak-makefile-am # no-op by default -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL $AUTOCONF $AUTOMAKE diff --git a/tests/remake9c.test b/tests/remake9c.test index 3328beb..32230f6 100755 --- a/tests/remake9c.test +++ b/tests/remake9c.test @@ -57,7 +57,6 @@ echo "AC_DEFUN([my_fingerprint], [BadBadBad])" > acinclude.m4 echo : > tweak-acinclude-m4 # no-op by default -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL $AUTOCONF $AUTOMAKE diff --git a/tests/remake9d.test b/tests/remake9d.test index ecb93d9..2267533 100755 --- a/tests/remake9d.test +++ b/tests/remake9d.test @@ -54,7 +54,6 @@ END echo cat > tweak-aclocal-m4 # no-op by default -$sleep # so that generated autotools files will be newer than prerequisites $ACLOCAL # Cheatingly mark aclocal.m4 as non auto-generated. sed '/^ *#.*generated automatically/d' aclocal.m4 > t -- 1.7.2.3