On 01/31/2012 01:55 PM, Peter Rosin wrote: > Hi, > > Here's a couple of missing AM_PROG_AR lines, ok for maint? > Alas no, because msvc is *not* merged into maint, so that we don't even have AM_PROG_AR in maint :-(
You might instead want to merge maint into msvc, then apply this patch to msvc, then merge msvc back into branch-1.11 and master. (I know, the present organization of branches sucks in some respects; we might rethink it after the 1.11.3 release, OK?) > Subject: [PATCH] tests: add AM_PROG_AR to help losing archivers > > * tests/extradep.test (configure.in): Add AM_PROG_AR. > * tests/extradep2.test (configure.in): Likewise. > By only reading this, I'm not sure whether the change is needed to pacify some automake warning, to improve coverage, or to make the tests runnable with Microsoft lib as the archiver. Could you add a paragraph after the summary line that explicitly specifies what is the patch motivation? ACK with that addressed. Thanks, Stefano
