On 02/02/2012 08:28 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>
>> Hi Jim, thanks for the quick review.
> ...
>>>> + $@ = "";
>>>> + eval { open3(*STDIN, *STDOUT, *STDERR, "am--no-such-command") };
>>>> + $@ =~ m/\bopen3:.*am--no-such-command/
>>>> + or die "Bad \$@ value: \"$@\"\n";
>>>> + '; then
>>>> + : # OK. IPC::Open3 should be good enough.
>>>> + else
>>>> + for s in '"missing plan" message' 'results'; do
>>>> + skip_ -r "IPC::Open3 not good enough" "no spurious $s"
>>>> + done
>>>
>>> Perhaps it's just your preferred style, but the quotes around 'results'
>>> are unnecessary, so I would remove them.
>>>
>> I'd rather leave them, for consistency with the other item
>> ('"missing plan" message'). Hope that's OK with you.
>
> consistency? They are required on the first term to quote the '"'s.
> There is no need for them in the latter.
>
> Of course, you're welcome to keep them in any case.
>
Thanks, I've kept them. Let's just call it "personal preference".
Best regards,
Stefano
