On 02/27/2012 11:01 PM, Dave Goodell wrote:
> "yacc-dist-nobuild.dir" fails without this depcomp patch, but it passes with
> it. I didn't fully grok this test, but it looks like the test requires
> dependency support from the compiler+depcomp to operate correctly.
>
Not really, that was a redundant dependency crept in because I almost
always test only with compilers for which automake supports automatic
dependency tracking.
> I don't have time to investigate this thoroughly, but you can
> reproduce it with GCC by running this test with
> "am_cv_CC_dependencies_compiler_type=none" set in the environment.
>
Indeed I can.
And the attached patch should fix the issue. I will push it tomorrow,
barring any objection.
Thanks,
Stefano
>From e36f246a790e1856cf6cb5a0aae37296c30d66a9 Mon Sep 17 00:00:00 2001
Message-Id: <e36f246a790e1856cf6cb5a0aae37296c30d66a9.1330456355.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Tue, 28 Feb 2012 20:07:34 +0100
Subject: [PATCH] tests: fix spurious failure when dependency tracking is
unavailable
Report by Dave Goodell. See automake bug#8880.
* tests/yacc-dist-nobuild.test: Run the sanity check that aims at
ensuring we really cover the expected code paths in a new build
directory, to avoid spurious failures when automatic dependency
tracking is disabled.
---
tests/yacc-dist-nobuild.test | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/yacc-dist-nobuild.test b/tests/yacc-dist-nobuild.test
index bdfaca6..6f02f11 100755
--- a/tests/yacc-dist-nobuild.test
+++ b/tests/yacc-dist-nobuild.test
@@ -76,9 +76,13 @@ cd build
$MAKE
# Sanity check.
-chmod u+w ../$distdir
-rm -f ../$distdir/parse.c
-chmod a-w ../$distdir
+cd ..
+chmod u+w $distdir
+rm -f $distdir/parse.c
+chmod a-w $distdir
+mkdir build2
+cd build2
+../$distdir/configure
$MAKE >out 2>&1 && { cat out; Exit 1; }
cat out
$FGREP parse.c out
--
1.7.9
