On 11/02/2012 09:22 PM, Eric Blake wrote: > On 11/02/2012 01:49 PM, Stefano Lattarini wrote: >> Reference: >> <http://lists.gnu.org/archive/html/autoconf-patches/2012-11/msg00004.html> >> >> On 11/02/2012 07:34 PM, Stefano Lattarini wrote: >>> Well, it turns out that such warnings are coming from the autom4te >>> invocation, so I see no simple, non-hacky way to avoid them, unless >>> we add a knob to autom4te itself. >>> >>> So, autoconfers: would be OK with you to add a new warning "category" >>> to autom4te that would suppress *only* this specific warning? >>> The warning in question being >>> >>> AC_FOO is m4_require'd but not m4_defun'd >>> >>> that is emitted by the '_m4_require_call' internal macro (defined in >>> 'lib/m4sugar/m4sugar.m4'). >>> >> Oh well, I went on and wrote a patch anyway. It should be good to go, >> maybe modulo the name of the new "singleton" warnings category; if anyone >> has a better name to suggest, shoot! > > Hmm, your idea turned out to be relatively simple; fewer lines than the > attempt I had of adding a new file to some but not all of the autom4te > languages to conditionally control the warning. > >> +++ b/lib/m4sugar/m4sugar.m4 >> @@ -2080,13 +2080,18 @@ m4_if([$0], [m4_require], [[m4_defun]], >> [[AC_DEFUN]])['d macro])])]dnl >> # >> # This is called frequently, so minimize the number of macro invocations >> # by avoiding dnl and other overhead on the common path. >> +# The use of convoluted warning category 'm4require-without-m4defun' is >> +# an hack required by aclocal to support AC_CONFIG_MACRO_DIRS without > > s/an hack/a hack/ > Consider this fixed. I will post a re-spin of the patch series tomorrow anyway; so you'll be able to double-check then.
> (The rule of thumb is that if the 'h' is aspirated, as in hack, then you > use 'a'; if the 'h' is silent, as in hour, then use 'an') > > ACK with that fix; and assuming I ever get around to reviewing the other > two patches that add AC_CONFIG_MACRO_DIRS in the first place (looking at > them now...) > Regards, Stefano
