-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi/2.
Eric Blake wrote: > On 09/22/2014 01:12 AM, KO Myung-Hun wrote: >> * Makefile.am: Subject. > > That's a very poor changelog entry. I'll leave it up to the > automake maintainer if it should be improved, though. > >> * t/Makefile.inc: Likewise. --- Makefile.am | 2 +- >> t/Makefile.inc | 4 ++-- 2 files changed, 3 insertions(+), 3 >> deletions(-) >> >> diff --git a/Makefile.am b/Makefile.am index 7e1c748..07c52c4 >> 100644 --- a/Makefile.am +++ b/Makefile.am @@ -72,7 +72,7 @@ >> generated_file_finalize = $(AM_V_at) \ # For some tests or >> targets, we need to have the just-build automake and # aclocal >> scripts avaiable on PATH. extend_PATH = \ - { >> PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export >> PATH; } + { PATH="$(abs_builddir)/t/wrap$(PATH_SEPARATOR)$$PATH" >> && export PATH; } > > Why are you changing this? I see no difference in the resulting > shell syntax, except that backslashes in $(abs_builddir) are now > handled differently. You need a lot more justification for WHY > this patch is necessary. > On OS/2, PATH_SEPARATOR is ';'. If is is not quoted, ';' works as a mark of end of sentence. And how about this for $(abs_builddir) ? At least, it works here. - { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export PATH; } + { PATH='$(abs_builddir)/t/wrap'"$(PATH_SEPARATOR)$$PATH" && export PATH; } - -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (OS/2) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFUINWdE9YstvghgroRArpmAJ4jYOV5myZeV9VCFXgbux6MCO2ZNACfc0RL ys7Xg5Oomf5JWJf2HQdQ1XE= =8t28 -----END PGP SIGNATURE-----